Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade all contracts and packages to cosmwasm-std beta8 #699

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Upgrade all contracts and packages to cosmwasm-std beta8 #699

merged 4 commits into from
Apr 11, 2022

Conversation

the-frey
Copy link
Contributor

@the-frey the-frey commented Apr 9, 2022 •
edited
Loading

Contracts using multi-test currently fail on cw-std beta8 because all addresses are now required to be normalized/lower case. This should fix that issue.

Specifically this is done by lower-casing the return value of the next_address function in multi-test.

@the-frey
Copy link
Contributor Author

the-frey commented Apr 9, 2022

Question: should this also update contracts to cosmwasm-std beta8 at the same time? That should then confirm the fix works for all contracts that are using multi-test.

@the-frey the-frey mentioned this pull request Apr 9, 2022
Merged
@maurolacy
Copy link
Contributor

Question: should this also update contracts to cosmwasm-std beta8 at the same time? That should then confirm the fix works for all contracts that are using multi-test.

Yes, please. Let's transform this into a "upgrade cosmwasm deps" PR, and this fix is part of it.

@the-frey
Copy link
Contributor Author

the-frey commented Apr 9, 2022 •
edited
Loading

@maurolacy cool, will do. Assume I should also increment versions 13.1 -> 13.2?

webmaster128
webmaster128 reviewed Apr 9, 2022
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

packages/multi-test/src/wasm.rs Outdated Show resolved Hide resolved
packages/multi-test/src/wasm.rs Show resolved Hide resolved
packages/multi-test/Cargo.toml Show resolved Hide resolved
@the-frey the-frey changed the title multi-test: upgrade to cw-std beta8 and fix next_address Upgrade all contracts and packages to cosmwasm-std beta8 Apr 9, 2022
@the-frey the-frey requested a review from webmaster128 April 9, 2022 13:10
ueco-jb
ueco-jb approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
but to be sure - does that address

Addr::unchecked(format!("contract{}", count))

supposed to be without separation?

packages/multi-test/src/wasm.rs Show resolved Hide resolved
@webmaster128
Copy link
Member

supposed to be without separation?

I think this is a matter of taste. It was Contract #0, Contract #1, … before and is now contract0, contract1, …. Having an address without spaces is a bit closer to reality. Since it is lower case letters followed by digits, it's still readable nicely.

@ueco-jb
Copy link
Contributor

ueco-jb commented Apr 11, 2022

If you put it that way, I'm all in favor.

@webmaster128 webmaster128 merged commit e2f07db into CosmWasm:main Apr 11, 2022
@the-frey the-frey deleted the the-frey/lowercase-mock-contract-names branch April 11, 2022 12:51
@tk-o tk-o mentioned this pull request Apr 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@the-frey @maurolacy @webmaster128 @ueco-jb